Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Mail to be had #2455

Closed
wants to merge 3 commits into from
Closed

Conversation

BlueHNT
Copy link
Contributor

@BlueHNT BlueHNT commented Jun 20, 2023

About The Pull Request

Added some more mail stuff.

Why It's Good For The Game

It's fun to get something interesting and unique that ain't a god damn spam.

Changelog

🆑
tweak: tweaked job specific mails
/:cl:

@bluewasabi24
Copy link
Contributor

bluewasabi24 commented Jun 20, 2023

Also, if you make any changes to the original code (code specifically not in the nsv13 folder), you need to notate it with //NSV13. Even if it's as small as changing the drop chance on something, you need to notate that so when we rebase, we know what to look for and update accordingly.

The first example I see is you updating line 36 as //BARTENDER as opposed to the original BART ENDER
While minor, you need to add the //NSV13 tag to the end of that as it is technically something you changed on code that's not originally ours.

Also, not required but a polite ask, but if you could stay true to the descending order of drop chance for your new items, I'd really appreciate it. An example would be line 80 and 81 for your added Brig Physician drops. It just keeps it clean and easy to reference.

@BlueHNT
Copy link
Contributor Author

BlueHNT commented Jun 20, 2023

Also, if you make any changes to the original code (code specifically not in the nsv13 folder), you need to notate it with //NSV13. Even if it's as small as changing the drop chance on something, you need to notate that so when we rebase, we know what to look for and update accordingly.

The first example I see is you updating line 36 as //BARTENDER as opposed to the original BART ENDER While minor, you need to add the //NSV13 tag to the end of that as it is technically something you changed on code that's not originally ours.

Also, not required but a polite ask, but if you could stay true to the descending order of drop chance for your new items, I'd really appreciate it. An example would be line 80 and 81 for your added Brig Physician drops. It just keeps it clean and easy to reference.

I have gone through some of the stuff and yes, I have noticed that I did put in some stuff incorrectly, I'm gonna revise it.

Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Power creep confirmed I'm denying these gamer items like atropine medipens, power tools, null rod and such

@BlueHNT
Copy link
Contributor Author

BlueHNT commented Jun 21, 2023

Power creep confirmed I'm denying these gamer items like atropine medipens, power tools, null rod and such

a bit yes, but I mean. Cargo techs straight up get a mosin. So it's kinda hard to draw a line

@BlueHNT
Copy link
Contributor Author

BlueHNT commented Jun 21, 2023

Power creep confirmed I'm denying these gamer items like atropine medipens, power tools, null rod and such

while I can understand power tools and null rod being a bit over the edge

You still get em quite easily along the round guaranteed, if you get 1 out of em earlier in the round, it won't ruin stuff, will it?

@BlueHNT
Copy link
Contributor Author

BlueHNT commented Jun 27, 2023

This thing sucks.

@BlueHNT BlueHNT closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants